Skip to content

Use unstableGitUpdater on my unstable packages#105713

Merged
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
fgaz:use-unstable-updater
Dec 3, 2020
Merged

Use unstableGitUpdater on my unstable packages#105713
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
fgaz:use-unstable-updater

Conversation

@fgaz
Copy link
Copy Markdown
Member

@fgaz fgaz commented Dec 2, 2020 •
edited
Loading

Motivation for this change

#101083 was merged, so now I can use unstableGitUpdater for my unstable packages.

(I also removed some stray newlines)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 2, 2020
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 2, 2020

Result of nixpkgs-review pr 105713 run on x86_64-linux 1

2 packages built:
  • bash-supergenpass
  • meme

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 2, 2020

Result of nixpkgs-review pr 105713 run on x86_64-darwin 1

1 package built:
  • meme

@SuperSandro2000 SuperSandro2000 merged commit 535c1da into NixOS:master Dec 3, 2020
@fgaz fgaz deleted the use-unstable-updater branch December 3, 2020 13:02
@ghost ghost mentioned this pull request Sep 22, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fgaz @SuperSandro2000