WIP: treewide: splice more nested package sets#105374
Closed
Ericson2314 wants to merge 1 commit intomasterfrom
Closed
WIP: treewide: splice more nested package sets#105374Ericson2314 wants to merge 1 commit intomasterfrom
Ericson2314 wants to merge 1 commit intomasterfrom
Conversation
14 tasks
FRidh
reviewed
Dec 19, 2020
|
|
||
| makeScopeWithSplicing = lib.makeScopeWithSplicing splicePackages pkgs.newScope; | ||
|
|
||
| topProjectedSpliced = attr: { |
Member
There was a problem hiding this comment.
Perhaps split attr on dots to allow for nested sets?
Member
|
I wonder how to access the buildPackages variant of pythonPackages, see b1d8335 |
|
I marked this as stale due to inactivity. → More info |
13 tasks
Member
|
replaced by #207652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
So far this just has some functions that might come in handy. Next step
is to find package sets that provide things used as non-buildInputs
(most of them seem to not fit that?).
I've always hated this splicing monster. Maybe others can tell me where
this might be worth it.
CC @FRidh @globin
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)