Skip to content

Comments

WIP: treewide: splice more nested package sets#105374

Closed
Ericson2314 wants to merge 1 commit intomasterfrom
wip/splice-more
Closed

WIP: treewide: splice more nested package sets#105374
Ericson2314 wants to merge 1 commit intomasterfrom
wip/splice-more

Conversation

@Ericson2314
Copy link
Member

Motivation for this change

So far this just has some functions that might come in handy. Next step
is to find package sets that provide things used as non-buildInputs
(most of them seem to not fit that?).

I've always hated this splicing monster. Maybe others can tell me where
this might be worth it.

CC @FRidh @globin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

So far this just has some functions that might come in handy. Next step
is to find package sets that provide things used as non-buildInputs
(most of them seem to not fit that?).

I've always hated this splicing monster. Maybe others can tell me where
this might be worth it.

CC @FRidh @globin
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 29, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 29, 2020 23:31

makeScopeWithSplicing = lib.makeScopeWithSplicing splicePackages pkgs.newScope;

topProjectedSpliced = attr: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps split attr on dots to allow for nested sets?

@FRidh
Copy link
Member

FRidh commented Mar 8, 2021

I wonder how to access the buildPackages variant of pythonPackages, see b1d8335

@stale
Copy link

stale bot commented Sep 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2021
@Artturin
Copy link
Member

replaced by #207652

@Artturin Artturin closed this Dec 25, 2022
@Artturin Artturin deleted the wip/splice-more branch April 7, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants