Skip to content

Comments

Add fcitx5#104658

Merged
teto merged 13 commits intoNixOS:masterfrom
poscat0x04:add-fcitx5
Jan 10, 2021
Merged

Add fcitx5#104658
teto merged 13 commits intoNixOS:masterfrom
poscat0x04:add-fcitx5

Conversation

@poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Nov 23, 2020

closes #102626

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and you are missing the meta infos.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 23, 2020
@poscat0x04
Copy link
Contributor Author

probably need to add a wrapped variant

@poscat0x04
Copy link
Contributor Author

I'm having trouble building libime, relevant build logs:

builder for '/nix/store/dxh4sd8lnjw0w6l1ffcjrbqw6jkddsxk-libime-1.0.1.drv' failed with exit code 2; last 10 log lines:
  cd /build/source/build/src/libime/core && /nix/store/s3j2gpc2s7cdn2wafm192jfp9k8jfvhs-gcc-wrapper-9.3.0/bin/g++ -DKENLM_MAX_ORDER=3 -DNDEBUG -I/build/source/build -I/build/source/src/libime/core/kenlm -Wall -Wextra  -O3 -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=c++17 -o CMakeFiles/kenlm.dir/kenlm/util/usage.cc.o -c /build/source/src/libime/core/kenlm/util/usage.cc
  [ 28%] Linking CXX static library libkenlm.a
  cd /build/source/build/src/libime/core && /nix/store/21cib7707fqxwg9xpjx0hfa5p9bx8hvh-cmake-3.18.4/bin/cmake -P CMakeFiles/kenlm.dir/cmake_clean_target.cmake
  cd /build/source/build/src/libime/core && /nix/store/21cib7707fqxwg9xpjx0hfa5p9bx8hvh-cmake-3.18.4/bin/cmake -E cmake_link_script CMakeFiles/kenlm.dir/link.txt --verbose=1
  /nix/store/p3kn26g5nhmx6spn37ar3mn0xjbzks3g-binutils-2.31.1/bin/ar qc libkenlm.a CMakeFiles/kenlm.dir/kenlm/lm/bhiksha.cc.o CMakeFiles/kenlm.dir/kenlm/lm/binary_format.cc.o CMakeFiles/kenlm.dir/kenlm/lm/config.cc.o CMakeFiles/kenlm.dir/kenlm/lm/lm_exception.cc.o CMakeFiles/kenlm.dir/kenlm/lm/model.cc.o CMakeFiles/kenlm.dir/kenlm/lm/quantize.cc.o CMakeFiles/kenlm.dir/kenlm/lm/read_arpa.cc.o CMakeFiles/kenlm.dir/kenlm/lm/search_hashed.cc.o CMakeFiles/kenlm.dir/kenlm/lm/search_trie.cc.o CMakeFiles/kenlm.dir/kenlm/lm/sizes.cc.o CMakeFiles/kenlm.dir/kenlm/lm/trie.cc.o CMakeFiles/kenlm.dir/kenlm/lm/trie_sort.cc.o CMakeFiles/kenlm.dir/kenlm/lm/value_build.cc.o CMakeFiles/kenlm.dir/kenlm/lm/virtual_interface.cc.o CMakeFiles/kenlm.dir/kenlm/lm/vocab.cc.o CMakeFiles/kenlm.dir/kenlm/util/bit_packing.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/bignum-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/bignum.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/cached-powers.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/diy-fp.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/double-conversion.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/fast-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/fixed-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/strtod.cc.o CMakeFiles/kenlm.dir/kenlm/util/ersatz_progress.cc.o CMakeFiles/kenlm.dir/kenlm/util/exception.cc.o CMakeFiles/kenlm.dir/kenlm/util/file.cc.o CMakeFiles/kenlm.dir/kenlm/util/file_piece.cc.o CMakeFiles/kenlm.dir/kenlm/util/float_to_string.cc.o CMakeFiles/kenlm.dir/kenlm/util/integer_to_string.cc.o CMakeFiles/kenlm.dir/kenlm/util/mmap.cc.o CMakeFiles/kenlm.dir/kenlm/util/murmur_hash.cc.o CMakeFiles/kenlm.dir/kenlm/util/parallel_read.cc.o CMakeFiles/kenlm.dir/kenlm/util/pool.cc.o CMakeFiles/kenlm.dir/kenlm/util/read_compressed.cc.o CMakeFiles/kenlm.dir/kenlm/util/scoped.cc.o CMakeFiles/kenlm.dir/kenlm/util/spaces.cc.o CMakeFiles/kenlm.dir/kenlm/util/string_piece.cc.o CMakeFiles/kenlm.dir/kenlm/util/usage.cc.o
  /nix/store/p3kn26g5nhmx6spn37ar3mn0xjbzks3g-binutils-2.31.1/bin/ranlib libkenlm.a
  make[2]: Leaving directory '/build/source/build'
  [ 28%] Built target kenlm
  make[1]: Leaving directory '/build/source/build'
  make: *** [Makefile:163: all] Error 2

not sure what caused the build to fail tho

@cireu
Copy link
Contributor

cireu commented Nov 23, 2020

You may wanna use release tarball in https://download.fcitx-im.org/fcitx5/ instead of fetchFromGithub.

@teto
Copy link
Member

teto commented Nov 23, 2020

Could you share the way to test this branch ?
My current config:

  i18n = {
     inputMethod = {
       enabled = "fcitx";
       fcitx.engines = with pkgs.fcitx-engines; [
         # mozc  # broken
         table-other # for arabic
         table-extra # for arabic
         # hangul
         m17n
     ];
     };
   };

Is it enough to set i18n.inputMethod.package = ?

@cireu
Copy link
Contributor

cireu commented Nov 24, 2020

I'm having trouble building libime, relevant build logs:

builder for '/nix/store/dxh4sd8lnjw0w6l1ffcjrbqw6jkddsxk-libime-1.0.1.drv' failed with exit code 2; last 10 log lines:
  cd /build/source/build/src/libime/core && /nix/store/s3j2gpc2s7cdn2wafm192jfp9k8jfvhs-gcc-wrapper-9.3.0/bin/g++ -DKENLM_MAX_ORDER=3 -DNDEBUG -I/build/source/build -I/build/source/src/libime/core/kenlm -Wall -Wextra  -O3 -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=c++17 -o CMakeFiles/kenlm.dir/kenlm/util/usage.cc.o -c /build/source/src/libime/core/kenlm/util/usage.cc
  [ 28%] Linking CXX static library libkenlm.a
  cd /build/source/build/src/libime/core && /nix/store/21cib7707fqxwg9xpjx0hfa5p9bx8hvh-cmake-3.18.4/bin/cmake -P CMakeFiles/kenlm.dir/cmake_clean_target.cmake
  cd /build/source/build/src/libime/core && /nix/store/21cib7707fqxwg9xpjx0hfa5p9bx8hvh-cmake-3.18.4/bin/cmake -E cmake_link_script CMakeFiles/kenlm.dir/link.txt --verbose=1
  /nix/store/p3kn26g5nhmx6spn37ar3mn0xjbzks3g-binutils-2.31.1/bin/ar qc libkenlm.a CMakeFiles/kenlm.dir/kenlm/lm/bhiksha.cc.o CMakeFiles/kenlm.dir/kenlm/lm/binary_format.cc.o CMakeFiles/kenlm.dir/kenlm/lm/config.cc.o CMakeFiles/kenlm.dir/kenlm/lm/lm_exception.cc.o CMakeFiles/kenlm.dir/kenlm/lm/model.cc.o CMakeFiles/kenlm.dir/kenlm/lm/quantize.cc.o CMakeFiles/kenlm.dir/kenlm/lm/read_arpa.cc.o CMakeFiles/kenlm.dir/kenlm/lm/search_hashed.cc.o CMakeFiles/kenlm.dir/kenlm/lm/search_trie.cc.o CMakeFiles/kenlm.dir/kenlm/lm/sizes.cc.o CMakeFiles/kenlm.dir/kenlm/lm/trie.cc.o CMakeFiles/kenlm.dir/kenlm/lm/trie_sort.cc.o CMakeFiles/kenlm.dir/kenlm/lm/value_build.cc.o CMakeFiles/kenlm.dir/kenlm/lm/virtual_interface.cc.o CMakeFiles/kenlm.dir/kenlm/lm/vocab.cc.o CMakeFiles/kenlm.dir/kenlm/util/bit_packing.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/bignum-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/bignum.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/cached-powers.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/diy-fp.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/double-conversion.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/fast-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/fixed-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/strtod.cc.o CMakeFiles/kenlm.dir/kenlm/util/ersatz_progress.cc.o CMakeFiles/kenlm.dir/kenlm/util/exception.cc.o CMakeFiles/kenlm.dir/kenlm/util/file.cc.o CMakeFiles/kenlm.dir/kenlm/util/file_piece.cc.o CMakeFiles/kenlm.dir/kenlm/util/float_to_string.cc.o CMakeFiles/kenlm.dir/kenlm/util/integer_to_string.cc.o CMakeFiles/kenlm.dir/kenlm/util/mmap.cc.o CMakeFiles/kenlm.dir/kenlm/util/murmur_hash.cc.o CMakeFiles/kenlm.dir/kenlm/util/parallel_read.cc.o CMakeFiles/kenlm.dir/kenlm/util/pool.cc.o CMakeFiles/kenlm.dir/kenlm/util/read_compressed.cc.o CMakeFiles/kenlm.dir/kenlm/util/scoped.cc.o CMakeFiles/kenlm.dir/kenlm/util/spaces.cc.o CMakeFiles/kenlm.dir/kenlm/util/string_piece.cc.o CMakeFiles/kenlm.dir/kenlm/util/usage.cc.o
  /nix/store/p3kn26g5nhmx6spn37ar3mn0xjbzks3g-binutils-2.31.1/bin/ranlib libkenlm.a
  make[2]: Leaving directory '/build/source/build'
  [ 28%] Built target kenlm
  make[1]: Leaving directory '/build/source/build'
  make: *** [Makefile:163: all] Error 2

not sure what caused the build to fail tho

I can't see a full log, but if the error was caused by linking std::filesystem>, try use GCC 9.

@poscat0x04
Copy link
Contributor Author

poscat0x04 commented Nov 27, 2020

I'm having trouble building libime, relevant build logs:

builder for '/nix/store/dxh4sd8lnjw0w6l1ffcjrbqw6jkddsxk-libime-1.0.1.drv' failed with exit code 2; last 10 log lines:
  cd /build/source/build/src/libime/core && /nix/store/s3j2gpc2s7cdn2wafm192jfp9k8jfvhs-gcc-wrapper-9.3.0/bin/g++ -DKENLM_MAX_ORDER=3 -DNDEBUG -I/build/source/build -I/build/source/src/libime/core/kenlm -Wall -Wextra  -O3 -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=c++17 -o CMakeFiles/kenlm.dir/kenlm/util/usage.cc.o -c /build/source/src/libime/core/kenlm/util/usage.cc
  [ 28%] Linking CXX static library libkenlm.a
  cd /build/source/build/src/libime/core && /nix/store/21cib7707fqxwg9xpjx0hfa5p9bx8hvh-cmake-3.18.4/bin/cmake -P CMakeFiles/kenlm.dir/cmake_clean_target.cmake
  cd /build/source/build/src/libime/core && /nix/store/21cib7707fqxwg9xpjx0hfa5p9bx8hvh-cmake-3.18.4/bin/cmake -E cmake_link_script CMakeFiles/kenlm.dir/link.txt --verbose=1
  /nix/store/p3kn26g5nhmx6spn37ar3mn0xjbzks3g-binutils-2.31.1/bin/ar qc libkenlm.a CMakeFiles/kenlm.dir/kenlm/lm/bhiksha.cc.o CMakeFiles/kenlm.dir/kenlm/lm/binary_format.cc.o CMakeFiles/kenlm.dir/kenlm/lm/config.cc.o CMakeFiles/kenlm.dir/kenlm/lm/lm_exception.cc.o CMakeFiles/kenlm.dir/kenlm/lm/model.cc.o CMakeFiles/kenlm.dir/kenlm/lm/quantize.cc.o CMakeFiles/kenlm.dir/kenlm/lm/read_arpa.cc.o CMakeFiles/kenlm.dir/kenlm/lm/search_hashed.cc.o CMakeFiles/kenlm.dir/kenlm/lm/search_trie.cc.o CMakeFiles/kenlm.dir/kenlm/lm/sizes.cc.o CMakeFiles/kenlm.dir/kenlm/lm/trie.cc.o CMakeFiles/kenlm.dir/kenlm/lm/trie_sort.cc.o CMakeFiles/kenlm.dir/kenlm/lm/value_build.cc.o CMakeFiles/kenlm.dir/kenlm/lm/virtual_interface.cc.o CMakeFiles/kenlm.dir/kenlm/lm/vocab.cc.o CMakeFiles/kenlm.dir/kenlm/util/bit_packing.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/bignum-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/bignum.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/cached-powers.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/diy-fp.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/double-conversion.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/fast-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/fixed-dtoa.cc.o CMakeFiles/kenlm.dir/kenlm/util/double-conversion/strtod.cc.o CMakeFiles/kenlm.dir/kenlm/util/ersatz_progress.cc.o CMakeFiles/kenlm.dir/kenlm/util/exception.cc.o CMakeFiles/kenlm.dir/kenlm/util/file.cc.o CMakeFiles/kenlm.dir/kenlm/util/file_piece.cc.o CMakeFiles/kenlm.dir/kenlm/util/float_to_string.cc.o CMakeFiles/kenlm.dir/kenlm/util/integer_to_string.cc.o CMakeFiles/kenlm.dir/kenlm/util/mmap.cc.o CMakeFiles/kenlm.dir/kenlm/util/murmur_hash.cc.o CMakeFiles/kenlm.dir/kenlm/util/parallel_read.cc.o CMakeFiles/kenlm.dir/kenlm/util/pool.cc.o CMakeFiles/kenlm.dir/kenlm/util/read_compressed.cc.o CMakeFiles/kenlm.dir/kenlm/util/scoped.cc.o CMakeFiles/kenlm.dir/kenlm/util/spaces.cc.o CMakeFiles/kenlm.dir/kenlm/util/string_piece.cc.o CMakeFiles/kenlm.dir/kenlm/util/usage.cc.o
  /nix/store/p3kn26g5nhmx6spn37ar3mn0xjbzks3g-binutils-2.31.1/bin/ranlib libkenlm.a
  make[2]: Leaving directory '/build/source/build'
  [ 28%] Built target kenlm
  make[1]: Leaving directory '/build/source/build'
  make: *** [Makefile:163: all] Error 2

not sure what caused the build to fail tho

I can't see a full log, but if the error was caused by linking std::filesystem>, try use GCC 9.

full build log: https://fars.ee/1Ria
The GCC version in use is 9.3.0.

@CoelacanthusHex
Copy link
Contributor

CoelacanthusHex commented Nov 27, 2020

full build log: fars.ee/1Ria
The GCC version in use is 9.3.0.

@poscat0x04
Maybe here:

libime> -- Downloading 'https://download.fcitx-im.org/data/table.tar.gz' to '/build/source/data/table.tar.gz'...
libime> -- Downloading 'https://download.fcitx-im.org/data/lm_sc.3gm.arpa-20140820.tar.bz2' to '/build/source/data/lm_sc.3gm.arpa-20140820.tar.bz2'...
libime> -- Downloading 'https://download.fcitx-im.org/data/dict.utf8-20200715.tar.xz' to '/build/source/data/dict.utf8-20200715.tar.xz'...
libime> CMake Error at table-dict-download-download.cmake:3 (file):
libime>   file DOWNLOAD HASH mismatch
libime>     for file: [/build/source/data/table.tar.gz]
libime>       expected hash: [6196053c724125e3ae3d8bd6b2f9172d0c83b65b0d410d3cde63b7a8d6ab87b7]
libime>         actual hash: [e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855]
libime>              status: [6;"Couldn't resolve host name"]
libime> CMake Error at opengram-lm-download-download.cmake:3 (file):
libime>   file DOWNLOAD HASH mismatch
libime>     for file: [/build/source/data/lm_sc.3gm.arpa-20140820.tar.bz2]
libime>       expected hash: [751bab7c55ea93a2cedfb0fbb7eb09f67d4da9c2c55496e5f31eb8580f1d1e2f]
libime>         actual hash: [e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855]
libime>              status: [6;"Couldn't resolve host name"]
libime> CMake Error at opengram-dict-download-download.cmake:3 (file):
libime>   file DOWNLOAD HASH mismatch
libime>     for file: [/build/source/data/dict.utf8-20200715.tar.xz]
libime>       expected hash: [23c36cd4df6de17f66bf2dfc453ec6c773641a479b6020c9e787552489c9c7d2]
libime>         actual hash: [e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855]
libime>              status: [6;"Couldn't resolve host name"]
libime> make[2]: *** [data/CMakeFiles/table-dict-download.dir/build.make:79: data/CMakeFiles/table-dict-download] Error 1
libime> make[2]: Leaving directory '/build/source/build'
libime> make[1]: *** [CMakeFiles/Makefile2:1360: data/CMakeFiles/table-dict-download.dir/all] Error 2
libime> make[1]: *** Waiting for unfinished jobs....
libime> make[2]: *** [data/CMakeFiles/opengram-lm-download.dir/build.make:79: data/CMakeFiles/opengram-lm-download] Error 1
libime> make[2]: Leaving directory '/build/source/build'
libime> make[1]: *** [CMakeFiles/Makefile2:1251: data/CMakeFiles/opengram-lm-download.dir/all] Error 2
libime> make[2]: *** [data/CMakeFiles/opengram-dict-download.dir/build.make:79: data/CMakeFiles/opengram-dict-download] Error 1
libime> make[2]: Leaving directory '/build/source/build'
libime> make[1]: *** [CMakeFiles/Makefile2:1139: data/CMakeFiles/opengram-dict-download.dir/all] Error 2

@cireu
Copy link
Contributor

cireu commented Nov 27, 2020

Tips: fcitx5-chinese-addons also requires a dict. Don't forget to prepare and populate it in the build recipe :P

@poscat0x04
Copy link
Contributor Author

Tips: fcitx5-chinese-addons also requires a dict. Don't forget to prepare and populate it in the build recipe :P

Fixed it. Right now fcitx5-chinese-addons still can't be built because of broken dependency qt515.qtwebkit

@poscat0x04 poscat0x04 force-pushed the add-fcitx5 branch 2 times, most recently from 80b5f8e to 4222dc8 Compare November 28, 2020 06:49
@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 28, 2020
@poscat0x04 poscat0x04 force-pushed the add-fcitx5 branch 2 times, most recently from c7dcb0c to 5291dcf Compare November 28, 2020 07:12
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 28, 2020
@poscat0x04 poscat0x04 marked this pull request as ready for review November 28, 2020 07:35
@teto
Copy link
Member

teto commented Dec 24, 2020

Looks like it needs xmodmap ?
when starting fcitx5:

7200  execve("/home/teto/.local/share/../bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/home/teto/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/run/wrappers/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/home/teto/.nix-profile/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/etc/profiles/per-user/teto/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/nix/var/nix/profiles/default/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/run/current-system/sw/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  execve("/nix/store/pn7higjfyh75k9h74fxkzhccl768h2xs-fcitx5-with-addons-5.0.3/bin/xmodmap", ["xmodmap", "/home/teto/.Xmodmap"], 0x7ffc8fc55388 /* 90 vars */) = -1 ENOENT (No such file or directory)
7200  write(2, "execvp: No such file or director"..., 34) = 34
7200  exit_group(1)                     = ?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104658 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
14 packages built:
  • fcitx5
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-gtk
  • fcitx5-lua
  • fcitx5-rime
  • fcitx5-table-extra
  • fcitx5-table-other
  • fcitx5-with-addons
  • libime
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt
  • xcb-imdkit

@poscat0x04
Copy link
Contributor Author

@teto It's probably optional.

@poscat0x04
Copy link
Contributor Author

ping @SuperSandro2000

@teto
Copy link
Member

teto commented Jan 5, 2021

It compiles but I've switch to wayland and haven't found a way to test it yet so if anyone else could check and merge 👍

@poscat0x04
Copy link
Contributor Author

ping @SuperSandro2000

@teto teto merged commit 9f8b7cb into NixOS:master Jan 10, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 10, 2021

Result of nixpkgs-review pr 104658 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
14 packages built:
  • fcitx5
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-gtk
  • fcitx5-lua
  • fcitx5-rime
  • fcitx5-table-extra
  • fcitx5-table-other
  • fcitx5-with-addons
  • libime
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt
  • xcb-imdkit

@poscat0x04 poscat0x04 deleted the add-fcitx5 branch January 10, 2021 15:01
FRidh added a commit that referenced this pull request Jan 11, 2021
#102168 moved Qt imports to qt5-packages.nix
and #104658 added a new package on the old
location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add the input method Fcitx5.

9 participants