Skip to content

mellowplayer: migrate to Qt5.15#104440

Merged
FRidh merged 1 commit intoNixOS:masterfrom
freezeboy:migrate-mellowplayer
Nov 23, 2020
Merged

mellowplayer: migrate to Qt5.15#104440
FRidh merged 1 commit intoNixOS:masterfrom
freezeboy:migrate-mellowplayer

Conversation

@freezeboy
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

Related to #104474

@SuperSandro2000
Copy link
Member

Can you rebase this branch on master to fix the eval error?

@freezeboy freezeboy force-pushed the migrate-mellowplayer branch from f811c37 to 85f08c0 Compare November 23, 2020 10:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 23, 2020
@FRidh FRidh merged commit 66be617 into NixOS:master Nov 23, 2020
@freezeboy freezeboy deleted the migrate-mellowplayer branch November 23, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants