Separate AdobeBlank-Regular.ttf from google-fonts package, moved to google-fonts.adobeBlank#103779
Conversation
modified: default.nix
ofborg
bot
added
10.rebuild-darwin: 0
|
|
||
| # This abomination of a font causes crashes with `libfontconfig', | ||
| # It has an absurd number of symbols | ||
| rm -r ofl/adobeblank/ |
There was a problem hiding this comment.
Maybe we could add outputs = [ "out" "adobeBlank" ]; after the version attribute and use moveToOutput share/fonts/truetype/something.ttf "$adobeBlank" where something.ttf are the file names of Adobe Blank font files in installPhase.
That way it will not be installed by default but interested people will still be able to install it using google-fonts.adobeBlank.
There was a problem hiding this comment.
That sounds like a good plan.
There was a problem hiding this comment.
I tried using moveToOutput during installPhase, but it wasn't working as expected.
I went ahead and did it the ol' fashioned way.
rm was necessary to prevent the font from being installed to $out.
I have tested google-fonts and google-fonts.adobeBlank, and they work as expected.
alex-ameen
changed the title
|
Thanks. |
2 participants
Motivation for this change
This absurdly large font causes
libfontconfigto get trapped processing for hours. It managed to break myemacsandthunderbirdpackages. (emacsdid manage to respond after 40+ hours of me leaving it to run,thunderbirddied immediately at startup ).Frankly I don't know what Adobe was aiming to do with this font, but it has over 550,000 symbols, which is enough to murder
fontconfig. Some "ancient wisdom" left in a log from a Google dev back in 2014 was helpful, as well as some discussions about a related issue withfontconfig#101813 and #73795I tested the build by itself, as well as across my usual NixOS system.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)