Skip to content

zathura: 0.4.5 -> 0.4.7#103727

Merged
jonringer merged 2 commits intoNixOS:masterfrom
jonringer:bump-zathura
Nov 13, 2020
Merged

zathura: 0.4.5 -> 0.4.7#103727
jonringer merged 2 commits intoNixOS:masterfrom
jonringer:bump-zathura

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 13, 2020

Motivation for this change

fix #100441 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

actually, doesn't fix the problem. But this problem has been identified here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237770

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 13, 2020
@jonringer
Copy link
Contributor Author

@timokau the pdf-mupdf extension wasn't linking against anything, I fixed that

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@jonringer
Copy link
Contributor Author

https://github.com/NixOS/nixpkgs/pull/103727
1 package built:
zathura

@delroth
Copy link
Contributor

delroth commented Jun 11, 2023

It turns out that this was probably the wrong fix re: mupdf linking errors: see #237199 which addresses the actual root cause of this issue.

Yes, about 3 years late with that comment, not sure if you want to follow up on this or leave it to the current maintainers :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants