Merged
Conversation
Also disable pgrep that depends on pkill
nomeata
reviewed
Nov 9, 2020
Contributor
nomeata
left a comment
There was a problem hiding this comment.
Thanks! Unfortunately, I can’t easily reproduce the issues that I was having (I don’t have access to a darwin machine, and this was on CI for a project where I cannot just test this patch.)
Member
Author
|
So installation was broken when implemented 4f52264, but I suppose it would only fail the build after #72347. Other places seem to have been fixed (e.g. ed61487): |
cole-h
pushed a commit
that referenced
this pull request
Mar 7, 2021
Still includes `coreutils` in `checkInputs`. macOS: disables some pexpect tests which depend on pkill/pgrep (see #103180).
rvem
pushed a commit
to serokell/nixpkgs
that referenced
this pull request
Nov 8, 2022
Also disable pgrep that depends on pkill (cherry picked from commit f0efe2d) cc NixOS#103180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also disable pgrep that depends on pkill
Motivation for this change
Closes: #82640
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)