Skip to content

skrooge: Use default Qt version#103067

Closed
alapshin wants to merge 1 commit intoNixOS:masterfrom
alapshin:skrooge
Closed

skrooge: Use default Qt version#103067
alapshin wants to merge 1 commit intoNixOS:masterfrom
alapshin:skrooge

Conversation

@alapshin
Copy link
Contributor

@alapshin alapshin commented Nov 7, 2020 •
edited
Loading

Motivation for this change

After PR #101369 was merged Skrooge uses different Qt version that other KDE applications. As a result Skrooge uses Fusion theme while all other applications use Breeze theme selected in KDE settings.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 7, 2020
@freezeboy
Copy link
Contributor

freezeboy commented Nov 7, 2020

PR #102840 also contains it

@alapshin
Copy link
Contributor Author

alapshin commented Nov 8, 2020

PR #102840 also contains it

Oh, my bad. I missed it somehow.

@alapshin alapshin closed this Nov 8, 2020
@alapshin alapshin deleted the skrooge branch November 8, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alapshin @freezeboy