Add step-ca 0.15.5 by dsx · Pull Request #102131 · NixOS/nixpkgs

dsx · 2020-10-30T04:35:14Z

Motivation for this change

Things done

[×] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- [×] NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[×] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[×] Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.

Removed unnecessary buildGoPackage.

Update description

SuperSandro2000 · 2020-11-25T23:06:17Z

@@ -0,0 +1,42 @@
+{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }:


Suggested change

{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }:

{ lib, buildGoModule, fetchFromGitHub }:

SuperSandro2000 · 2020-11-25T23:16:22Z

+let
+  sha256 = "01y4wi6j1frfpd6ndwrxw4sr9rwhj8m96mvp76rnszzwgvlydgd4";
+  vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5";
+  version = "0.15.5";
+in
+buildGoModule {
+  inherit vendorSha256;
+  inherit version;
+  pname = "step-ca";


Suggested change

let

sha256 = "01y4wi6j1frfpd6ndwrxw4sr9rwhj8m96mvp76rnszzwgvlydgd4";

vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5";

version = "0.15.5";

in

buildGoModule {

inherit vendorSha256;

inherit version;

pname = "step-ca";

buildGoModule rec {

version = "0.15.5";

pname = "step-ca";

SuperSandro2000 · 2020-11-25T23:16:35Z

+  pname = "step-ca";
+
+  src = fetchFromGitHub {
+    inherit sha256;


Suggested change

inherit sha256;

sha256 = "1zr78p2jxhajqv59kwqqq02njzr4s20ddixyh2ki95p6afniw7wp";

SuperSandro2000 · 2020-11-25T23:16:42Z

+    rev = "v${version}";
+  };
+
+  goPackagePath = "github.com/smallstep/certificates";


Suggested change

goPackagePath = "github.com/smallstep/certificates";

goPackagePath = "github.com/smallstep/certificates";

vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5";

SuperSandro2000 · 2020-11-25T23:17:10Z

+
+  buildPhase = ''
+    runHook preBuild
+    CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca


Suggested change

CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca

CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca

runHook postBuild

SuperSandro2000 · 2020-11-25T23:23:54Z

Why did you not update the 0.13.X version?

dsx · 2020-11-27T20:25:56Z

I haven't read step-ca change log.

AluisioASG · 2020-12-21T15:29:18Z

Is this still being worked on?

SuperSandro2000

Please squash the commits and change PR and commit title to step-ca: init at 0.15.5

mohe2015 · 2021-01-24T21:45:10Z

@dsx I don't understand but isn't this version already in master? https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/step-ca/default.nix

AluisioASG · 2021-01-24T22:51:09Z

I don't understand but isn't this version already in master? https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/step-ca/default.nix

Indeed, looks like it's covered by #93711.

SuperSandro2000 · 2021-01-25T14:55:44Z

Good catch! Closing as duplicate. Maybe we want to add an alias for this?

mohe2015 · 2021-01-25T15:56:18Z

@SuperSandro2000 There already exist step-ca and step-cli (https://github.com/NixOS/nixpkgs/tree/master/pkgs/tools/security) so I think it's fine. These are two tools from the smallstep organization.

ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 30, 2020

ofborg bot requested review from CMCDragonkai and kalbasit October 30, 2020 04:46

Add step-ca 0.15.5

497ce9e

luc65r suggested changes Oct 30, 2020

View reviewed changes

Comment thread pkgs/tools/security/step-ca/0.15.nix

Comment thread pkgs/tools/security/step-ca/0.15.nix

Comment thread pkgs/tools/security/step-ca/0.15.nix Outdated

Comment thread pkgs/tools/security/step-ca/0.15.nix Outdated

dsx added 5 commits October 30, 2020 16:41

Update 0.15.nix

d8b101c

Removed unnecessary buildGoPackage.

Update default.nix

7181015

Update 0.15.nix

4cec1d1

Update description

Update 0.15.nix

83b03bf

Update default.nix

7dd706c

luc65r reviewed Oct 30, 2020

View reviewed changes

Comment thread pkgs/tools/security/step-ca/default.nix Outdated

dsx added 4 commits October 30, 2020 18:20

Update default.nix

607f82b

Update 0.15.nix

7ab0dc1

Update 0.15.nix

be19b75

Update 0.15.nix

9e88b95

SuperSandro2000 reviewed Nov 25, 2020

View reviewed changes

SuperSandro2000 requested changes Jan 18, 2021

View reviewed changes

SuperSandro2000 closed this Jan 25, 2021

		@@ -0,0 +1,42 @@
		{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }:

	{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }:
	{ lib, buildGoModule, fetchFromGitHub }:

	inherit sha256;
	sha256 = "1zr78p2jxhajqv59kwqqq02njzr4s20ddixyh2ki95p6afniw7wp";

	CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca
	CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca
	runHook postBuild

Uh oh!

Conversation

dsx commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuperSandro2000 Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Nov 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 commented Nov 25, 2020

Uh oh!

dsx commented Nov 27, 2020

Uh oh!

AluisioASG commented Dec 21, 2020

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

mohe2015 commented Jan 24, 2021

Uh oh!

AluisioASG commented Jan 24, 2021

Uh oh!

SuperSandro2000 commented Jan 25, 2021

Uh oh!

mohe2015 commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dsx commented Oct 30, 2020 •

edited

Loading

SuperSandro2000 Nov 25, 2020 •

edited

Loading

mohe2015 commented Jan 25, 2021 •

edited

Loading