Skip to content

nodePackages: Switch to 14.x#101936

Merged
marsam merged 1 commit intoNixOS:masterfrom
punkeel:punkeel/nodejs-14-lts
Nov 19, 2020
Merged

nodePackages: Switch to 14.x#101936
marsam merged 1 commit intoNixOS:masterfrom
punkeel:punkeel/nodejs-14-lts

Conversation

@punkeel
Copy link
Contributor

@punkeel punkeel commented Oct 28, 2020

Motivation for this change

12.x is still maintained by Node, but 14.15.0 became the new LTS version of Node.js.
As per #89184, nodejs should point to the current LTS.

Bump the default nodejs version from 12 to 14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This PR does not introduce a new package or changes to an existing one. If anything breaks, it will be packages that depend on it - and I don't have the resources (or knowledge 😬 ) to list + test them.

12.x is still maintained by Node, but 14.15.0 became the new LTS version of Node.js.
As per NixOS#89184, `nodejs` should point to the current LTS.

Bump the default `nodejs` version from 12 to 14.
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 28, 2020
@marsam marsam merged commit 8826488 into NixOS:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants