Skip to content

x265: fix linux-aarch64 build#101594

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:x265-aarch64
Oct 25, 2020
Merged

x265: fix linux-aarch64 build#101594
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:x265-aarch64

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 24, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Oct 24, 2020

see https://hydra.nixos.org/build/128517825

@Mic92 Mic92 changed the title x265: fix aarch64 build x265: fix linux-aarch64 build Oct 24, 2020
@ofborg ofborg bot requested a review from codyopel October 24, 2020 20:22
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 24, 2020
@ajs124
Copy link
Member

ajs124 commented Oct 25, 2020

How does this relate to #100807?

@thefloweringash thefloweringash mentioned this pull request Oct 25, 2020
Closed
10 tasks
@Mic92 Mic92 merged commit 2257afa into NixOS:master Oct 25, 2020
@Mic92 Mic92 deleted the x265-aarch64 branch October 25, 2020 19:58
@Mic92
Copy link
Member Author

Mic92 commented Oct 25, 2020

This one does not enable 10bit and 12bit support. It might be still worth to pursue it for aarch64, but the patch here is an easy fix to get everything related to video codes working again on aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyopel codyopel Awaiting requested review from codyopel

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mic92 @ajs124

Comments