Skip to content

.github/workflows/editorconfig.yml: check indent_style#101530

Merged
zowoq merged 3 commits intoNixOS:masterfrom
zowoq:ecc-tabs
Nov 10, 2020
Merged

.github/workflows/editorconfig.yml: check indent_style#101530
zowoq merged 3 commits intoNixOS:masterfrom
zowoq:ecc-tabs

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 24, 2020

When we first started with this editorconfig-checker only supported disabling the indentation check, upstream has since added support for disabling indent_size which would allow us to check only indent_style (spaces vs tabs).

indent_size would still be a bit disruptive to enable but I think indent_style would be fine.

check errors files in pkgs/*
Current ~700 ~400
Current + indent_style ~2000 ~550
Current + indent_style (with excludes) ~1400 ~500
Current + indent_{size,style} ~60000 ~1950

I'll fix everything outside pkgs (doc, nixos, etc) which is an extra ~250 errors in ~20 files.

@zowoq zowoq requested a review from Mic92 as a code owner October 24, 2020 05:37
@ofborg ofborg bot added 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 24, 2020
@zowoq zowoq marked this pull request as draft October 28, 2020 09:40
@zowoq
Copy link
Contributor Author

zowoq commented Nov 7, 2020

Hmm, I don't think I meant to switch this to a draft.

@zowoq zowoq marked this pull request as ready for review November 7, 2020 01:53
@zowoq zowoq merged commit 4b5c6c8 into NixOS:master Nov 10, 2020
@zowoq zowoq deleted the ecc-tabs branch November 10, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants