.github/workflows/editorconfig.yml: check indent_style#101530
Merged
zowoq merged 3 commits intoNixOS:masterfrom Nov 10, 2020
zowoq:ecc-tabs
Merged
.github/workflows/editorconfig.yml: check indent_style#101530zowoq merged 3 commits intoNixOS:masterfrom zowoq:ecc-tabs
zowoq merged 3 commits intoNixOS:masterfrom
zowoq:ecc-tabs
Conversation
Contributor
Author
|
Hmm, I don't think I meant to switch this to a draft. |
Mic92
approved these changes
Nov 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we first started with this
editorconfig-checkeronly supported disabling the indentation check, upstream has since added support for disablingindent_sizewhich would allow us to check onlyindent_style(spaces vs tabs).indent_sizewould still be a bit disruptive to enable but I thinkindent_stylewould be fine.pkgs/*I'll fix everything outside
pkgs(doc,nixos, etc) which is an extra ~250 errors in ~20 files.