pythonPackages.rpy2: 3.2.6 -> 3.3.6, fix test etc.#101327
Merged
jonringer merged 1 commit intoNixOS:masterfrom Nov 24, 2020
Merged
pythonPackages.rpy2: 3.2.6 -> 3.3.6, fix test etc.#101327jonringer merged 1 commit intoNixOS:masterfrom
jonringer merged 1 commit intoNixOS:masterfrom
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
- This newer version is compatible with panda 1.0 without any patch. - rPackages.lazyload is required to run tests. - The official website is moved to GitHub Pages. Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Member
|
This builds for me on NixOS 20.09, and appears to work as expected, based on https://rpy2.github.io/doc/v3.3.x/html/introduction.html#graphics-and-plots |
Contributor
Author
Member
|
Fails to build for me on linux-x86_64: I am working on darwin support which fails due to missing dependencies in R. Does not build on darwin because of #103624 |
Contributor
Author
|
Thank you for testing, @SuperSandro2000! |
jonringer
approved these changes
Nov 24, 2020
Contributor
jonringer
left a comment
There was a problem hiding this comment.
overall LGTM
https://github.com/NixOS/nixpkgs/pull/101327
2 packages built:
python37Packages.rpy2 python38Packages.rpy2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation for this change
This change updates
rpy2to the latest version and rebases a local patch to that version.Fixes #81345.
Fixes #100259.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)