Skip to content

rsync: Work around upstream cross-compilation issue#101204

Merged
samueldr merged 1 commit intoNixOS:masterfrom
samueldr:fix/rsync-cross-compilation-regression
Oct 26, 2020
Merged

rsync: Work around upstream cross-compilation issue#101204
samueldr merged 1 commit intoNixOS:masterfrom
samueldr:fix/rsync-cross-compilation-regression

Conversation

@samueldr
Copy link
Member

It should be fixed by the next release:

Already a part of the updates for 3.2.4

Note that for non-cross, this is a no-op!

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It should be fixed by the next release:

 * RsyncProject/rsync@b7fab6f

Already a part of the updates for 3.2.4

 * https://download.samba.org/pub/rsync/NEWS#3.2.4
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 20, 2020
@samueldr samueldr merged commit 9119d71 into NixOS:master Oct 26, 2020
@samueldr samueldr deleted the fix/rsync-cross-compilation-regression branch October 26, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant