pkgs/top-level/aliases.nix: improve error messages#101174
Merged
jtojnar merged 1 commit intoNixOS:masterfrom Oct 22, 2020
Merged
pkgs/top-level/aliases.nix: improve error messages#101174jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
jtojnar
reviewed
Oct 21, 2020
Change error messages to start with or at least mention the name of the package being referenced. This avoids obscure error messages like "error: Abandoned by upstream." when rebuilding your system. Also do some trivial cosmetic changes while touching things.
xaverdh
force-pushed
the
aliases-throws-names
branch
from
a74f08e to
9c3bc4a
Compare
Contributor
Author
|
(rebased) |
Member
|
Nice, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change error messages in
aliases.nixto start with or at least mention the name of thepackage being referenced. This avoids obscure error messages like
"error: Abandoned by upstream." when rebuilding your system.
Also do some trivial cosmetic changes while touching things.
Motivation for this change
See #101098 for an example of the issue.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)