Skip to content

Append '-unstable' to pname instead of prefixing to version#101138

Closed
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:append-unstable-to-pname
Closed

Append '-unstable' to pname instead of prefixing to version#101138
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:append-unstable-to-pname

Conversation

@raboof
Copy link
Copy Markdown
Member

@raboof raboof commented Oct 20, 2020

As documented in https://nixos.org/manual/nixpkgs/stable/#sec-package-naming
the '-unstable' should be appended to the pname, not prepended to the version.

Motivation for this change

For consistency. Confirmed by @Niksnut on IRC that this is still the consensus.

I tried to check 'pname' wasn't used for other things, but I'm sure I missed a
few spots. Will fix those based on CI results.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation labels Oct 20, 2020
@raboof raboof force-pushed the append-unstable-to-pname branch 4 times, most recently from 9627344 to 0bd5e57 Compare October 20, 2020 15:20
@raboof
Append '-unstable' to pname instead of prefixing to version
d0e6136 
As documented in https://nixos.org/manual/nixpkgs/stable/#sec-package-naming
the '-unstable' should be appended to the pname, not prepended to the version.

Confirmed by @Niksnut on IRC that this is still the consensus.

I tried to check 'pname' wasn't used for other things, but I'm sure I missed a
few spots. Will fix those based on CI results.
@raboof raboof force-pushed the append-unstable-to-pname branch from 0bd5e57 to d0e6136 Compare October 20, 2020 15:41
@xaverdh
Copy link
Copy Markdown
Contributor

xaverdh commented Oct 20, 2020

If this is indeed the official policy and will be merged, can we add a check to ofborg or something to enforce this in new pull requests?

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Oct 20, 2020
@gebner
Copy link
Copy Markdown
Member

gebner commented Oct 20, 2020

We're currently discussing changing the naming convention so that -unstable becomes a suffix of the version: #100833

@raboof
Copy link
Copy Markdown
Member Author

raboof commented Oct 20, 2020

We're currently discussing changing the naming convention so that -unstable becomes a suffix of the version: #100833

Ah, thanks, bad timing for this PR then 😞

@raboof raboof closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raboof @xaverdh @gebner