Skip to content

Comments

[20.09] percona-server: 5.6.43-84.3 -> 5.6.49-89.0 (#97923)#101039

Merged
jonringer merged 1 commit intoNixOS:release-20.09from
jfroche:fix/percona-server
Oct 19, 2020
Merged

[20.09] percona-server: 5.6.43-84.3 -> 5.6.49-89.0 (#97923)#101039
jonringer merged 1 commit intoNixOS:release-20.09from
jfroche:fix/percona-server

Conversation

@jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 18, 2020

Fixes build with recent versions of glibc.

ZHF: #97479
Backport: #97923
Fix: https://hydra.nixos.org/build/127623766

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche
percona-server: 5.6.43-84.3 -> 5.6.49-89.0 (NixOS#97923)
6a5f9b3 
Fixes build with recent versions of glibc.

ZHF: NixOS#97479(cherry picked from commit c15bcdd)
@ofborg ofborg bot requested a review from grahamc October 18, 2020 22:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 18, 2020
@jfroche
Copy link
Contributor Author

jfroche commented Oct 18, 2020

Result of nixpkgs-review pr 101039 1

1 package built:
  • percona-server

jonringer
jonringer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101039 1

1 package built:
  • percona-server (percona-server56)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grahamc grahamc Awaiting requested review from grahamc

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfroche @jonringer