python3Packages.Theano: add pythonImportsCheck#100867
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Oct 17, 2020
Merged
Conversation
ofborg
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
mweinelt
reviewed
Oct 17, 2020
this not only gives us a "hint" of test coverage, but also proves the fix from NixOS#97597 allows import of theano from within a sandboxed build
risicle
force-pushed
the
ris-theano-imports-check
branch
from
e9ef4bd to
4a9dba6
Compare
Contributor
|
@ofborg eval |
Member
|
Result of 1 package failed to build:
7 packages built:
|
mweinelt
approved these changes
Oct 17, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This not only gives us a "hint" of test coverage, but also proves the fix from #97597 allows import of
theanofrom within a sandboxed build.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)