darwin: update xcode versions#100687
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Bump. I wonder also if there might be a way to get requireXcode accessible externally, so that overrideAttrs could be used to add new versions too. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-create-custom-cross-compile-overlay/10832/3 |
|
cc @NixOS/darwin-maintainers |
|
I would change the commit message to be |
|
I haven't done this on github, would I amend and force-push the local branch, or push another commit, or is the rename to the ticket name enough? There are some newer versions that I can add to this. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/trying-to-get-ios-working/10991/1 |
|
Should be fixed. Let me know if there are any other issues
On Wed, Jan 20, 2021 at 08:40 Matthew Bauer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/os-specific/darwin/xcode/default.nix
<#100687 (comment)>:
>
let requireXcode = version: sha256:
let
xip = "Xcode_" + version + ".xip";
# TODO(alexfmpe): Find out how to validate the .xip signature in Linux
- unxip = if stdenv.isDarwin
+ unxip = if targetPlatform.isDarwin
this should be stdenv or buildPlatform ~ users will use these instructions
on the machine their building things, not what they're targeting
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#100687 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVRX5DPRZHFGJMZEUFJAC3S24BQ3ANCNFSM4SS5EBBQ>
.
--
- Steven
|
Motivation for this change
All XCode versions listed are quite old
Things done
'hello' should build, but this needs more comprehensive testing imho.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)