Skip to content

darwin: update xcode versions#100687

Merged
matthewbauer merged 4 commits intoNixOS:masterfrom
spease:add-newer-xcode-hashes
Jan 24, 2021
Merged

darwin: update xcode versions#100687
matthewbauer merged 4 commits intoNixOS:masterfrom
spease:add-newer-xcode-hashes

Conversation

@spease
Copy link
Contributor

@spease spease commented Oct 16, 2020

Motivation for this change

All XCode versions listed are quite old

Things done

'hello' should build, but this needs more comprehensive testing imho.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 16, 2020
@SuperSandro2000 SuperSandro2000 requested a review from LnL7 November 27, 2020 14:44
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/compiling-for-ios/10776/1

@spease
Copy link
Contributor Author

spease commented Jan 5, 2021

Bump. I wonder also if there might be a way to get requireXcode accessible externally, so that overrideAttrs could be used to add new versions too.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-create-custom-cross-compile-overlay/10832/3

@jonringer
Copy link
Contributor

cc @NixOS/darwin-maintainers

@jonringer
Copy link
Contributor

I would change the commit message to be darwin: update xcode versions , as that's more inline with the changes you are proposing

@spease
Copy link
Contributor Author

spease commented Jan 6, 2021

I haven't done this on github, would I amend and force-push the local branch, or push another commit, or is the rename to the ticket name enough? There are some newer versions that I can add to this.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trying-to-get-ios-working/10991/1

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 20, 2021
@spease spease mentioned this pull request Jan 20, 2021
9 tasks
@spease
Copy link
Contributor Author

spease commented Jan 20, 2021 via email

@matthewbauer matthewbauer merged commit 84408a6 into NixOS:master Jan 24, 2021
@spease spease deleted the add-newer-xcode-hashes branch January 24, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants