Skip to content

sbt: use sbt-launcher-package.#10062

Merged
edwtjo merged 1 commit intoNixOS:masterfrom
gebner:sbt-loader-package
Oct 12, 2015
Merged

sbt: use sbt-launcher-package.#10062
edwtjo merged 1 commit intoNixOS:masterfrom
gebner:sbt-loader-package

Conversation

@gebner
Copy link
Member

@gebner gebner commented Sep 25, 2015

Change the sbt package to use the official package for sbt instead of an ad-hoc wrapper of the ivy build. This package uses the launcher script from sbt-launcher-package which is also used in the debian, rpm, windows packages, and the arch linux package (i.e. by everyone as far as I can tell).

In particular, per-project .sbtopts files are supported now.

cc @rickynils

@edwtjo
Copy link
Member

edwtjo commented Sep 26, 2015

👍 from me

@gebner
Copy link
Member Author

gebner commented Oct 12, 2015

Is there anything missing for this to be merged?

edwtjo added a commit that referenced this pull request Oct 12, 2015
@edwtjo edwtjo merged commit c10caef into NixOS:master Oct 12, 2015
@edwtjo
Copy link
Member

edwtjo commented Oct 12, 2015

No, I was waiting for @rickynils but let's merge it.

Thanks!

@puffnfresh
Copy link
Member

Good stuff 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants