apache-kafka: replace ParNew to G1 YoungGeneration#100115
Closed
GTrunSec wants to merge 2 commits intoNixOS:masterfrom
Closed
apache-kafka: replace ParNew to G1 YoungGeneration#100115GTrunSec wants to merge 2 commits intoNixOS:masterfrom
GTrunSec wants to merge 2 commits intoNixOS:masterfrom
Conversation
10 tasks
asbachb
reviewed
Oct 12, 2020
Contributor
There was a problem hiding this comment.
I wonder if there's a need to be explicit since G1 should be default GC since java 9.
Contributor
Author
There was a problem hiding this comment.
https://github.com/apache/kafka/blob/aba9036eb681597911343510e246de4fc547a479/bin/kafka-run-class.sh#L257. I think, the option of default should be matched with this line of the shell. otherwise, I can remove the default flags to list of example such as XX:+DisableExplicitGC was replaced by -XX:+ExplicitGCInvokesConcurrent in the default JVM settings. may this will be a good way to comment for users. it does not matter the flag is default setting or not. Or set the default list to empty(the example list as explain option).
2ca24ff to
6cc8a8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
UseParNewGChas been deprecated in JDK 9 and removed in JDK 10.you can find info from here:
Dropping support for CMS and then removing the CMS code, or at least more thoroughly segregating it, will reduce the maintenance burden of the GC code base and accelerate new development. The G1 garbage collector is intended, in the long term, to be a replacement for most uses of CMS.the issue output will be like this:
Things done
NOTICE: the ignoring warning will be sloved in second commit.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)