Skip to content

Comments

qt5.qtwebengine: Sessions restore patch#100041

Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/qt/webengine-patch
Closed

qt5.qtwebengine: Sessions restore patch#100041
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/qt/webengine-patch

Conversation

@doronbehar
Copy link
Contributor

Per #99456 (comment)

cc @ttuegel .

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 8, 2020
@doronbehar doronbehar requested a review from ttuegel as a code owner October 8, 2020 17:30
@doronbehar doronbehar mentioned this pull request Oct 8, 2020
10 tasks
@ofborg ofborg bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Oct 8, 2020
@ofborg ofborg bot requested a review from matthewbauer October 8, 2020 17:52
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 8, 2020
@doronbehar doronbehar changed the base branch from staging to master October 8, 2020 21:05
@doronbehar doronbehar force-pushed the pkg/qt/webengine-patch branch from 13506ca to 2547b3d Compare October 8, 2020 21:05
@doronbehar doronbehar force-pushed the pkg/qt/webengine-patch branch from 2547b3d to 6ef704c Compare October 8, 2020 21:07
@doronbehar
Copy link
Contributor Author

Targeting PR to master.

@The-Compiler
Copy link
Contributor

Note this isn't a security patch - it patches crashes happening with Qt 5.15.1 which make it almost unusable otherwise, but they are not security related.

What I meant in #99456 (comment) is that it's a bad idea for the qutebrowser package to depend on Qt 5.14 instead of 5.15.

@doronbehar
Copy link
Contributor Author

it patches crashes happening with Qt 5.15.1

Now I notice our qt5.15 is qt5.15.0 but the patch applies to it as well. It's still good to apply it right?

@doronbehar
Copy link
Contributor Author

Fixed the commit message.

@doronbehar doronbehar force-pushed the pkg/qt/webengine-patch branch from 6ef704c to b206142 Compare October 13, 2020 16:03
@The-Compiler
Copy link
Contributor

Now I notice our qt5.15 is qt5.15.0 but the patch applies to it as well. It's still good to apply it right?

Surely doesn't hurt. I don't know which change between Qt 5.15.0 and .1 triggered the issue.

@doronbehar doronbehar changed the title qt5.qtwebengine: Security patch qt5.qtwebengine: Sessions restore patch Oct 14, 2020
@doronbehar doronbehar removed the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 14, 2020
@gebner gebner mentioned this pull request Oct 31, 2020
10 tasks
@doronbehar
Copy link
Contributor Author

Closed in favor of #102216 .

@doronbehar doronbehar closed this Nov 5, 2020
@doronbehar doronbehar deleted the pkg/qt/webengine-patch branch March 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants