Skip to content

nixos/mediatomb: fix doc errors#100034

Merged
timokau merged 1 commit intoNixOS:masterfrom
timokau:mediatomb-fixes
Oct 8, 2020
Merged

nixos/mediatomb: fix doc errors#100034
timokau merged 1 commit intoNixOS:masterfrom
timokau:mediatomb-fixes

Conversation

@timokau
Copy link
Member

@timokau timokau commented Oct 8, 2020 •
edited
Loading

Motivation for this change

Fix the manual build.

#93450 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
nixos/mediatomb: fix doc errors
a4cde0f 
Follow-up to NixOS#93450 to fix the manual build.
@timokau timokau mentioned this pull request Oct 8, 2020
Merged
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2020
@timokau timokau merged commit 0fa60e2 into NixOS:master Oct 8, 2020
@timokau timokau deleted the mediatomb-fixes branch October 8, 2020 14:44
@ardumont
Copy link
Contributor

ardumont commented Oct 8, 2020

Thanks for the heads up.

@timokau timokau changed the title Mediatomb fixes nixos/mediatomb: fix doc errors Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timokau @ardumont