Skip to content

Comments

[staging] python38Packages.importlib-metadata: return null#100017

Closed
jonringer wants to merge 1 commit intoNixOS:stagingfrom
jonringer:importlib-metadata-null
Closed

[staging] python38Packages.importlib-metadata: return null#100017
jonringer wants to merge 1 commit intoNixOS:stagingfrom
jonringer:importlib-metadata-null

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 8, 2020

Motivation for this change

This is a backport, packages are discouraged not to use it

wondering if this is feasible, it's about a 280K closure size saving in a few thousand packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is a backport, packages are discouraged not to use it
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 8, 2020
@FRidh
Copy link
Member

FRidh commented Oct 20, 2020

We should avoid setting something to null, but it is however convenient/pragmatic.

@jonringer
Copy link
Contributor Author

The main issue is there's an import mismatch "importlib.metadata" vs "importlib_metada" (backport)

The saving is only ~280K, but it would still be nice to get rid of it.

@Vonfry
Copy link
Member

Vonfry commented Nov 27, 2020

This package is old, should we update it as well?

pypi: url

@jonringer
Copy link
Contributor Author

This package is old, should we update it as well?

We should probably do that as part of a large update.

cc @FRidh did you want to do a python-unstable bump?

@FRidh
Copy link
Member

FRidh commented Nov 27, 2020

cc @FRidh did you want to do a python-unstable bump?

"want" isn't how I would put it, but yes, I think it is about time again.

@jonringer
Copy link
Contributor Author

"want" isn't how I would put it, but yes, I think it is about time again.

Did you want me to do it? Just so that the process is able to be done by more than one person?

@FRidh FRidh added this to the 21.05 milestone Mar 20, 2021
@FRidh
Copy link
Member

FRidh commented Mar 24, 2021

cc @FRidh did you want to do a python-unstable bump?

#117452

@jonringer
Copy link
Contributor Author

importlib-metadata has been updated to backport 3.10 behavior. this is no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants