[staging] python38Packages.importlib-metadata: return null#100017
[staging] python38Packages.importlib-metadata: return null#100017jonringer wants to merge 1 commit intoNixOS:stagingfrom
Conversation
This is a backport, packages are discouraged not to use it
|
We should avoid setting something to null, but it is however convenient/pragmatic. |
|
The main issue is there's an import mismatch "importlib.metadata" vs "importlib_metada" (backport) The saving is only ~280K, but it would still be nice to get rid of it. |
|
This package is old, should we update it as well? pypi: url |
We should probably do that as part of a large update. cc @FRidh did you want to do a |
"want" isn't how I would put it, but yes, I think it is about time again. |
Did you want me to do it? Just so that the process is able to be done by more than one person? |
|
importlib-metadata has been updated to backport 3.10 behavior. this is no longer relevant |
Motivation for this change
This is a backport, packages are discouraged not to use it
wondering if this is feasible, it's about a 280K closure size saving in a few thousand packages
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)