eval: use a work directory instead of an environment variable to control the Nix expression#84
Merged
infinisil merged 1 commit intoNixOS:mainfrom Jul 21, 2024
Conversation
…rol the Nix expression No test used the `NIX_CHECK_BY_NAME_EXPR_PATH` to change the Nix file that was read, and it's simple to rebuild in order to test out changes to the `src/eval.nix`.
willbush
approved these changes
Jul 21, 2024
Member
willbush
left a comment
willbush
left a comment
There was a problem hiding this comment.
LGTM, but I'd wait for @infinisil review. He has a much better understanding of this than I do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This reduces the list of environment variables needed in order to use the unwrapped
nixpkgs-check-nametool to one:NIX_CHECK_BY_NAME_NIX_PACKAGE. #79 now needs to use the unwrapped tool in order to control which Nix is used in an integration test, but it shouldn't have to figure this detail out.No test used the
NIX_CHECK_BY_NAME_EXPR_PATHto change the Nix file that was read, and it's simpler and shorter to rebuild in order to test out changes to thesrc/eval.nix.Things Done
runtimeExprPathNIX_CHECK_BY_NAME_EXPR_PATHenvironment variableeval.nixin the binary