Do not encourage merging with CI failure#198
Merged
philiptaron merged 1 commit intoNixOS:mainfrom Feb 18, 2026
Merged
Conversation
Replace "Merging is discouraged but would not break the base branch" with "Please fix them before merging" in the DiscouragedPatternedIntroduced status message. With required status checks now in place, the old message incorrectly reassured contributors that merging was safe despite a red CI check. Fixes NixOS#174
qweered
approved these changes
Feb 16, 2026
MattSturgeon
approved these changes
Feb 17, 2026
mdaniels5757
approved these changes
Feb 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "Merging is discouraged but would not break the base branch" with "Please fix them before merging" in the
DiscouragedPatternedIntroducedstatus message. With required status checks now in place, the old message incorrectly reassured contributors that merging was safe despite a red CI checkFixes #174