Merged
Conversation
It seems that we now need an explicit dependency on nix to get nix-prefetch-url. It also seems that openssh is required for git to work (as is required by npins and cargo), at least locally for me. This may be due to my local configuration? Even if it is, I think there's minimal harm in adding the requirement.
Contributor
|
All other PRs fail CI, this one does not. Let's do it. |
wolfgangwalther
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we now need an explicit dependency on nix to get nix-prefetch-url. This causes CI to fail, both on pull requests and on scheduled jobs (e.g. https://github.com/NixOS/nixpkgs-vet/actions/runs/18845166075/job/53767161451).
It also seems that openssh is required for git to work (as is required by npins and cargo), at least locally for me. This may be due to my local configuration? Even if it is, I think there's minimal harm in adding the requirement.