Skip to content

Drop nix minimum to fix CI#177

Merged
willbush merged 6 commits intoNixOS:mainfrom
willbush:drop-nix-minimum
Sep 28, 2025
Merged

Drop nix minimum to fix CI#177
willbush merged 6 commits intoNixOS:mainfrom
willbush:drop-nix-minimum

Conversation

@willbush
Copy link
Copy Markdown
Member

@willbush willbush commented Sep 27, 2025

upstream nixVersions.minimum got dropped:

NixOS/nixpkgs@cc3d229

also see: NixOS#171 (comment)

also ran npins update and treefmt to get local nix-build -A ci passing.

edit: went ahead and did cargo upgrade --incompatible / update too. I had to back rowan version to 0.15 to keep it compatible with rnix.

upstream `nixVersions.minimum` got dropped:

NixOS/nixpkgs@cc3d229

also see: NixOS#171 (comment)
@wolfgangwalther
Copy link
Copy Markdown
Contributor

I don't know what the CI failure means, rerunning it didn't work.

@willbush
Copy link
Copy Markdown
Member Author

I don't know what the CI failure means, rerunning it didn't work.

looking. I'll fix before merging.

@willbush willbush force-pushed the drop-nix-minimum branch 3 times, most recently from fab4f97 to 185ed56 Compare September 28, 2025 03:31
@willbush willbush disabled auto-merge September 28, 2025 03:32
@willbush willbush enabled auto-merge September 28, 2025 04:01
@willbush willbush merged commit 07cb92a into NixOS:main Sep 28, 2025
3 checks passed
@willbush
Copy link
Copy Markdown
Member Author

finally got this working. got easier after I realized I could repro locally with nix-build -A autoPrUpdate && ./result/bin/auto-pr-update . then comment out some of the scripts that need a github token. npins was failing when running via autoPrUpdate and it's error message was getting swallowed in CI making the whole thing confusing. fix was simply npin upgrade. Added code to echo the output when auto-pr-update script fails.

@willbush willbush deleted the drop-nix-minimum branch September 28, 2025 05:37
@mdaniels5757 mdaniels5757 mentioned this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants