Merged
Conversation
Unlikely this will ever be an issue, but probably would perfer it to be an explicit error since it would indicate another more serious issue is going on.
Member
Author
|
@Ben-PH feel free to review too! (Github won't let me add you as a reviewer) |
6f563c7 to
0b9ceec
Compare
Ben-PH
reviewed
Nov 8, 2024
Contributor
Ben-PH
left a comment
There was a problem hiding this comment.
I like it.
Minor, inconsequential nit, but the map_or_else functions might be able to use Path::display (similar to "instead of |s| s.to_string(), use str::to_string"), but you do you.
0b9ceec to
13e4a61
Compare
Member
Author
Not seeing a way to do that without dropping the |
Contributor
|
Missed the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #124, but this time fewer pedantic lint fixes and cleaner git history.