Clear some clippy::pedantic pings#120
Merged
philiptaron merged 4 commits intoNixOS:mainfrom Oct 28, 2024
Merged
Conversation
Ben-PH
commented
Oct 28, 2024
philiptaron
requested changes
Oct 28, 2024
Contributor
There was a problem hiding this comment.
Looks good to me other than the one highlighted spot. Thank you for the contribution!
cargo fmt needs to be run as well, as CI highlights.
src/eval.rs
Outdated
| | (false, Some(_)) | ||
| // Something like `<attr> = bar` where `bar = pkgs.callPackage ...` | ||
| | (true, None) => { | ||
| (_, None) | (false, Some(_)) => { |
Contributor
There was a problem hiding this comment.
Please revert or find another way of expressing the comments, like extracting to a function or something. Humans are bad at understanding what the _ in these expressions actually means in nixpkgs already, and the removal of the comments makes it much worse. I'd much rather have a longer function than to miss this.
Contributor
Author
|
format done, requested change reversion done. Appologies for the skipped fmt. |
philiptaron
approved these changes
Oct 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is probably one (tiny) step above scraping doc-comments and passing it through a spell-checker. I just ran clippy with
#![warn(clippy::pedantic)], clearing the lints and/or specifically allowing lints until it was clear. I just hope this is a net positive for you.I noticed this project mentioned in the nixconf recording, and thought I'd have a look. This is a first-pass, and would be happy to provide more substantive PRs.