Number every problem reported by nixpkgs-vet#109
Merged
philiptaron merged 40 commits intoNixOS:mainfrom Oct 5, 2024
Merged
Conversation
This tool is called `nixpkgs-vet`. Implicitly, every thing it talks about is prefixed by "nixpkgs", so it doesn't need the explicit prefix.
We have to do a little work to transition the callsite, but it all works.
It's more about structure than anything else, and it's used here primarily.
Let's automate it with the `derive-new` proc macro.
… with their NPV number in their module
Member
|
I'll get a chance to look at this closer tomorrow or this weekend |
Contributor
Author
|
Gentle ping to review if you've got the cycles to spend. |
13 tasks
Member
|
@philiptaron Sorry for the wait! Seems like good changes all around to me. More widespread usage of |
willbush
approved these changes
Oct 5, 2024
Member
|
Nice work @philiptaron, and thanks for reviewing @willbush! Sorry that I'm not very available recently 😅 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes
Description of changes
nixpkgs-vetDisplaywith the exact same error as previouslyto_validationclosureThis PR is best reviewed commit-by-commit.