Conversation
Fixes #30 by having the retirement script check whether the person was made a committer in the past year and exiting early in that case. The committer addition times were manually back-filled based on the past years announcements in https://github.com/NixOS/nixpkgs/issues/50105, but the sync script will add the times going forward.
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Wolfgang's trained me to read JavaScript for these sorts of things instead of bash. I hate to say it, but it is nicer in JavaScript. 🫣
| - A local Git clone of this repository with the `origin` remote set to the test repository: | ||
| ```bash | ||
| git remote add upstream git@github.com:NixOS/nixpkgs-committers.git | ||
| git remote set-url origin git@github.com:infinisil-test-org/nixpkgs-committers.git | ||
| ``` |
There was a problem hiding this comment.
This change is only needed because of the instructions below, as I read it, and not because the tool now relies on the git history. Is that correct?
There was a problem hiding this comment.
This is actually an unrelated change to just improve the testing, because the script always pushes to a remote named origin
I guess a separate commit would be in order, though I don't think it's essential
|
|
||
| # Don't remove people that have been added recently | ||
| if [[ -s "$login" ]]; then | ||
| epochAdded=$(date --date="$(<"$login")" +%s) |
There was a problem hiding this comment.
I support these "member files" becoming JSON and having much more information in them, in the fullness of time.
There was a problem hiding this comment.
Hard to imagine what could go in it that wouldn't be in the maintainer list 🤔
After NixOS/nixpkgs-committers#31, people who received commit access since a year ago were tracked with the date of commit bit reception. While this works, it's not necessary in the long term, because the git history will keep track of when commit bits are given. This change starts using the commit history when possible, which allows avoiding the need for adding addition dates for new committers.
After #31, people who received commit access since a year ago were tracked with the date of commit bit reception. While this works, it's not necessary in the long term, because the git history will keep track of when commit bits are given. This change starts using the commit history when possible, which allows avoiding the need for adding addition dates for new committers.
4 participants
Fixes NixOS/nixpkgs#30 by having the retirement script check whether the person was made a committer in the past year and exiting early in that case.
The committer addition times were manually back-filled based on the past years announcements in #60, but the sync script will add the times going forward.
For reference, here are the announcements:
I already tested this with the testing procedure, resulting in infinisil-test-org/nixpkgs-committers#25, but no other PR despite a new user without activity.