Add rest of Radxa devices that alredy have U-Boot package in nixpkgs #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This order works better when we have more SoCs.
We might refactor some parts again when we add Amlogic and Allwinner supports.
RadxaYuntian
commented
Feb 7, 2025
Comment on lines
+61
to
+66
| # Or, if the default platform firmware is not available in the NixOS version you are using: | ||
| # (import nixos-hardware.nixosModules.rock-pi-e { | ||
| # lib = nixpkgs-unfree.lib; | ||
| # config = nixpkgs-unfree.config; | ||
| # pkgs = nixpkgs-unfree.legacyPackages.aarch64-linux; | ||
| # }) |
There was a problem hiding this comment.
Currently, ROCK Pi E's U-Boot package is not available in NixOS 24.11, so we need to override the module input at importing time, since its hardware.rockchip.platformFirmware is resolved before we can override it later.
However, this looks pretty ugly, so I'm wondering if there is more elegant way to do it.
BTW we do need an example for how to use U-Boot in non stable nixpkgs, since I plan to add them after NixOS/nixpkgs/pull/374482 and one of the A-TF 2.10->2.12 PR is merged.
Previously, it was a product-level option with a default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
u-boot.itbandidbloader.img, and so far the installation offsets are the same across 3 different SoCs.Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake inputAll 3 new devices and the existing ROCK 4C+ are tested.