hetzner: Don't create /root/.ssh/authorized_keys.#349
Merged
edolstra merged 1 commit intoNixOS:masterfrom Oct 26, 2015
Merged
Conversation
I have no idea why I didn't use users.extraUsers.root.openssh.authorizedKeys.keys in the first place, but since NixOS/nixpkgs@6e76765 it's necessary to do so with users.mutableUsers set to false. This is good, because now we shouldn't have cruft like .ssh/authorized_keys laying around just for NixOps to work. However, I didn't look into the other backends whether they work with mutableUsers = false, because I'm not able to properly test them. Also, please note that we still have to users.extraUsers instead of users.users, because we want to retain backwards-compatibility. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig
force-pushed
the
hetzner-mutable-users
branch
from
1fe75c8 to
93bea39
Compare
aszlig
added a commit
to aszlig/nixops
that referenced
this pull request
Oct 23, 2015
hetzner: Don't create /root/.ssh/authorized_keys.
aszlig
added a commit
to openlab-aux/vuizvui
that referenced
this pull request
Oct 23, 2015
Instead of merging all those PRs via the patches attribute, I've now created a branch that has all those PRs merged, which are: * NixOS/nixops#201: Use dedicated SSH keypair for "none" backend * NixOS/nixops#348: Fixup and refactor Hetzner backend tests * NixOS/nixops#349: hetzner: Don't create /root/.ssh/authorized_keys * NixOS/nixops#350: Fix tests for the "none" backend So our version of NixOps now should now correctly cope with users.mutableUsers set to false. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
edolstra
added a commit
that referenced
this pull request
Oct 26, 2015
hetzner: Don't create /root/.ssh/authorized_keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes configurations with
users.mutableUsers = false.I have no idea why I didn't use
users.extraUsers.root.openssh.authorizedKeys.keysin the first place, but since NixOS/nixpkgs@6e76765 it's necessary to do so withusers.mutableUsersset to false.This is good, because now we shouldn't have cruft like
.ssh/authorized_keyslaying around just for NixOps to work.However, I didn't look into the other backends whether they work with
mutableUsers = false, because I'm not able to properly test them.