Merged
Conversation
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This is needed in order to build the initrd for the target machines and we don't have access to external network resources within the VM test. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This is only a source for more errors, confusion, more complexity and we really don't want to test the packet filter here, because we already have tests in NixOS directly. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are cherry-picked commits from #201 so that we have working VM tests in master and can base further branches and pull requests on a state with working tests instead of constantly needing to cherry-pick again and again.
Jobset on my Hydra: https://headcounter.org/hydra/jobset/nixops/fix-vm-tests#tabs-jobs