Don't print the first bracket in values in magenta in error messages#9929
Merged
thufschmitt merged 1 commit intoNixOS:masterfrom Feb 8, 2024
Merged
Conversation
This fixes the opening bracket of lists/attrsets being printed in magenta, unlike the closing bracket. NixOS#9753 (comment)
9999years
force-pushed
the
dont-print-values-in-magenta
branch
from
e351f5e to
9646d62
Compare
thufschmitt
approved these changes
Feb 8, 2024
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
…enta Don't print the first bracket in values in magenta in error messages (cherry picked from commit 46a0625) Change-Id: I8435565c87db182116140eaeea9df1243e67ea94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes the opening bracket of lists/attrsets being printed in magenta, unlike the closing bracket.
Noticed in #9753 (comment)
Before:
After:
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.