Skip to content

Expose locals from let expressions to the debugger#9918

Merged
thufschmitt merged 2 commits intoNixOS:masterfrom
9999years:debugger-locals-for-let-expressions
Feb 8, 2024
Merged

Expose locals from let expressions to the debugger#9918
thufschmitt merged 2 commits intoNixOS:masterfrom
9999years:debugger-locals-for-let-expressions

Conversation

@9999years
Copy link
Contributor

Motivation

Closes #8827.

With this file:

let
  r = [];
  x = builtins.throw r;
in
  x

Before:

$ nix eval --file test.nix --debugger
error: cannot coerce a list to a string

nix-repl> :env
Env level 0
builtins true false ...

After:

$ nix eval --file test.nix --debugger
error: cannot coerce a list to a string: [ ]

nix-repl> :env
Env level 0
static: x r

Env level 1
builtins true false ...

nix-repl> r
[ ]

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@9999years 9999years requested a review from edolstra as a code owner February 3, 2024 03:34
@thufschmitt thufschmitt merged commit acef4f1 into NixOS:master Feb 8, 2024
@9999years 9999years deleted the debugger-locals-for-let-expressions branch February 8, 2024 16:36
lf- added a commit to lf-/nix that referenced this pull request Mar 6, 2024
lf- added a commit to lf-/nix that referenced this pull request Mar 6, 2024
lf- added a commit to lf-/nix that referenced this pull request Mar 6, 2024
lf- added a commit to lf-/nix that referenced this pull request Mar 10, 2024
lf- added a commit to lf-/nix that referenced this pull request Mar 10, 2024
lf- added a commit to lf-/nix that referenced this pull request Mar 13, 2024
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
…expressions

Expose locals from `let` expressions to the debugger

(cherry picked from commit acef4f1)
Change-Id: Ib3623254f67ac762f4e7230d625e9f87dff38a84
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
Change-Id: Ib0591e1499c5dba5e5a83ee75a899c9d16986827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Debugger cannot get locals in some instances

2 participants