Ensure all store types support "real" URIs#9850
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom May 21, 2024
Merged
Conversation
github-actions
bot
added
the
store
Ericson2314
force-pushed
the
missing-store-urls
branch
from
8b238ac to
cbf479e
Compare
github-actions
bot
added
the
with-tests
thufschmitt
approved these changes
Jan 25, 2024
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Nice :)
I'm not really convinced by the switch to an std::optional for the authority parameter (we nearly always convert it straight away to an empty string, so we just end-up with std::optional{""} == std::nullopt), but the extra consistency for the rest is very nice
edolstra
reviewed
Jan 29, 2024
Ericson2314
force-pushed
the
missing-store-urls
branch
from
31a1cce to
17b0a12
Compare
Ericson2314
commented
Jan 30, 2024
Ericson2314
force-pushed
the
missing-store-urls
branch
from
17b0a12 to
d95eedd
Compare
Member
Author
|
Got rid of the |
In particular `local://<path>` and `unix://` (without any path) now work, and mean the same things as `local` and `daemon`, respectively. We thus now have the opportunity to desguar `local` and `daemon` early. This will allow me to make a change to NixOS#9839 requested during review to desugar those earlier. Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
Ericson2314
force-pushed
the
missing-store-urls
branch
from
d95eedd to
470c050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In particular
local://<path>andunix://(without any path) now work, and mean the same things aslocalanddaemon, respectively. We thus now have the opportunity to desguarlocalanddaemonearly.Context
This will allow me to make a change to #9839 requested during review to desugar those earlier.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.