getNameFromURL(): Support uppercase characters in attribute names#9657
getNameFromURL(): Support uppercase characters in attribute names#9657edolstra merged 1 commit intoNixOS:masterfrom
Conversation
In particular, this makes it handle 'legacyPackages' correctly.
| /* ----------- tests for url-name.hh --------------------------------------------------*/ | ||
|
|
||
| TEST(getNameFromURL, getsNameFromURL) { | ||
| TEST(getNameFromURL, getNameFromURL) { |
There was a problem hiding this comment.
The getNameFromURL function is only used in nix profile and its complexity seems like a potential liability for reproducibility.
- Does this change break existing profile manifests?
- Could you move it into
profile.cc?
There was a problem hiding this comment.
Moving it there could be a logic next step of getting it out of libutil as I proposed, but then we will have a hard time unit testing it if we still want to?
There was a problem hiding this comment.
I would, however, not mind a libprofile with all things profile related!
There was a problem hiding this comment.
Short of having a library for each group of commands, we could compile the CLI as a static library, so that we can at least unit test anything.
While there's something to be said for exposing all logic to potential library users, I also think that decisions about public interfaces shouldn't block testing, which is more of a basic necessity.
There was a problem hiding this comment.
Maybe getNameFromURL should be moved, but that's orthogonal to this PR since this function already existed.
In particular, this makes it handle 'legacyPackages' correctly. (cherry picked from commit 936a364) Upstream-PR: NixOS/nix#9657 Change-Id: Icc4efe02f7f8e90a2970589f72fd3d3cd4418d95
In particular, this makes it handle 'legacyPackages' correctly. (cherry picked from commit 936a364) Upstream-PR: NixOS/nix#9657 Change-Id: Icc4efe02f7f8e90a2970589f72fd3d3cd4418d95
3 participants
Motivation
In particular, this makes it handle
legacyPackagescorrectly.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.