Skip to content

Fix clang devshell#9613

Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom
jlesquembre:jl/clang-stdenv
Dec 15, 2023
Merged

Fix clang devshell#9613
Ericson2314 merged 2 commits intoNixOS:masterfrom
jlesquembre:jl/clang-stdenv

Conversation

@jlesquembre
Copy link
Member

Issue introduced in #9535

Motivation

native-clang11StdenvPackages dev shell is missing some tooling.

Following the steps from https://nixos.org/manual/nix/stable/contributing/hacking.html#editor-integration :

make clean && bear -- make -j$NIX_BUILD_CORES default check install

returns an error

Context

Priorities

Add 👍 to pull requests you find important.

Issue introduced in NixOS#9535
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlesquembre Thank you! Can you put this stuff in the override of nix for the dev shell rather than the package proper? That would be better since it is not actually needed for any build

@jlesquembre
Copy link
Member Author

@Ericson2314 done, thanks for your feedback.

Let me know if it's ok now.

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ericson2314 Ericson2314 merged commit 419a64f into NixOS:master Dec 15, 2023
@jlesquembre jlesquembre deleted the jl/clang-stdenv branch December 15, 2023 15:26
@fricklerhandwerk fricklerhandwerk added the build-problem Nix fails to compile or test; also improvements to build process label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-problem Nix fails to compile or test; also improvements to build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants