Revert "Switch from std::regex to boost::regex"#9508
Merged
roberth merged 2 commits intoNixOS:masterfrom Dec 1, 2023
Merged
Conversation
infinisil
requested review from
edolstra,
fricklerhandwerk and
roberth
as code owners
infinisil
requested review from
roberth and
thufschmitt
and removed request for
edolstra,
fricklerhandwerk and
roberth
This was referenced Nov 30, 2023
roberth
approved these changes
Dec 1, 2023
github-actions
bot
added
the
with-tests
Member
Author
|
Now also added a simple regression test for exactly the reported regex. I confirmed that it succeeds only with this PR. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7762, because it caused a regression, as reported by @9999years in #7762 (comment), with a Nixpkgs fix in NixOS/nixpkgs#271245