Improve ACL clearing support (fixing FreeBSD build)#9491
Merged
edolstra merged 1 commit intoNixOS:masterfrom Nov 30, 2023
Merged
Improve ACL clearing support (fixing FreeBSD build)#9491edolstra merged 1 commit intoNixOS:masterfrom
edolstra merged 1 commit intoNixOS:masterfrom
Conversation
The problem was that f880469 forgot that the `#include <sys/xattr.h>` was guarded by an `#ifdef __linux__`. However, the build failure was only on FreeBSD --- turns out other platforms have this header too! The fix therefore uses a new configure check so we properly clear ACLs on more platforms.
github-actions
bot
added
the
store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The problem was that f880469 forgot that the
#include <sys/xattr.h>was guarded by an#ifdef __linux__.However, the build failure was only on FreeBSD --- turns out other platforms have this header too!
Context
f880469 is from #9394
Priorities
Add 👍 to pull requests you find important.