Use buildprefix in a few more places#9465
Merged
edolstra merged 1 commit intoNixOS:masterfrom Nov 30, 2023
Merged
Conversation
Ericson2314
requested review from
edolstra,
fricklerhandwerk and
thufschmitt
as code owners
github-actions
bot
added
the
with-tests
Contributor
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
There was a problem hiding this comment.
What a natural thing to have and do, one would think.
edolstra
reviewed
Nov 29, 2023
| clean-files += Makefile.config | ||
| include mk/directories.mk | ||
|
|
||
| -include $(buildprefix)Makefile.config |
Member
There was a problem hiding this comment.
This seems circular. E.g. prefix is set in Makefile.config and mk/directories.mk depends on the value of prefix, so Makefile.config needs to be included before mk/directories.mk.
Maybe only the setting of buildprefix should be moved to before -include $(buildprefix)Makefile.config?
Member
Author
There was a problem hiding this comment.
I think it worked because the way non-:= definitions are "lazy", but I do prefer your way because it is easier to understand. Done!
Ericson2314
force-pushed
the
build-dir
branch
from
d2c6753 to
d1ba024
Compare
`installcheck` doesn't yet work, but the rest of the build can now happen mostly inside a separate build directory. Progress on NixOS#9342 Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Ericson2314
force-pushed
the
build-dir
branch
from
d1ba024 to
52e0911
Compare
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Use `buildprefix` in a few more places (cherry picked from commit b6a3fde) Change-Id: I2790663fa9f8242ac2db6582b7e421d2fdf42942
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
installcheckdoesn't yet work, but the rest of the build can now happen mostly inside a separate build directory.Context
Progress on #9342
Priorities
Add 👍 to pull requests you find important.