Merged
Conversation
Ericson2314
approved these changes
Oct 16, 2023
Member
|
Thank you! |
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Fix broken move (cherry picked from commit aa4f41d) Change-Id: I39d3f9f4f27328500de005c9205d905c55d6f9ea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While randomly reading code, i discovered this bug.
Context
A moved-from object in C++ is in valid, but undefined state. This means that you can for example destruct or reassign it, but not use it in any context that has certain assumptions on its content.
The
set(...)function uses theemplacemethod on the moved-from object (which is a map), and that is not allowed in that context before reassigning an empty map.Priorities
Add 👍 to pull requests you find important.