Add protocol versions to {Worker,Serve}Proto::*Conn#9157
Merged
roberth merged 2 commits intoNixOS:masterfrom Oct 20, 2023
Merged
Add protocol versions to {Worker,Serve}Proto::*Conn#9157roberth merged 2 commits intoNixOS:masterfrom
{Worker,Serve}Proto::*Conn#9157roberth merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
with-tests
This makes the code clearer, and will help us replace them with proper structs and get rid of the macros later.
This will allow us to factor out logic, which is currently scattered inline, into several reusable instances The tests are also updated to support versioning. Currently all Worker and Serve protocol tests are using the minimum version, since no version-specific serialisers have been created yet. But in subsequent commits when that changes, we will test individual versions to ensure complete coverage.
Ericson2314
force-pushed
the
protocol-versions
branch
from
5742f41 to
e36c917
Compare
thufschmitt
added
the
idea approved
roberth
approved these changes
Oct 20, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-20-nix-team-meeting-minutes-96/34557/1 |
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Add protocol versions to `{Worker,Serve}Proto::*Conn`
(cherry picked from commit 4d17c59)
Change-Id: I497af39deb792e50c157a1305d8c9e722798740b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This will allow us to factor out logic, which is currently scattered inline, into several reusable instances
Context
The tests are also updated to support versioning. Currently all Worker and Serve protocol tests are using the minimum version, since no version-specific serialisers have been created yet. But in subsequent commits when that changes, we will test individual versions to ensure complete coverage.
Priorities
Add 👍 to pull requests you find important.