Merged
Conversation
also use fancier formatting so the example blocks are easier to discern from the description.
Ericson2314
reviewed
Sep 26, 2023
Ericson2314
reviewed
Sep 26, 2023
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Otherwise seems good from a quick glance
Ericson2314
reviewed
Sep 27, 2023
Co-authored-by: John Ericson <git@JohnEricson.me>
Ericson2314
reviewed
Oct 9, 2023
Co-authored-by: John Ericson <git@JohnEricson.me>
Ericson2314
approved these changes
Oct 20, 2023
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
This looks very nice @fricklerhandwerk!
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-20-nix-team-meeting-minutes-96/34557/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also use fancier formatting so the example blocks are easier to discern
from the description.
Motivation
We need more examples. Also we should provide visual aids to give structure to long sections of text.
Context
This work is sponsored by Antithesis ✨
Priorities
Add 👍 to pull requests you find important.