Skip to content

docker: publish images to ghcr.io#8066

Merged
fricklerhandwerk merged 4 commits intoNixOS:masterfrom
baloo:baloo/docker/publish-to-ghcr
Oct 20, 2023
Merged

docker: publish images to ghcr.io#8066
fricklerhandwerk merged 4 commits intoNixOS:masterfrom
baloo:baloo/docker/publish-to-ghcr

Conversation

@baloo
Copy link
Member

@baloo baloo commented Mar 18, 2023

Motivation

docker.com announced their intention to remove the free plan used by OSS. The nixos/nix image is essential to various CI runs to build with nix. To provide a continuity plan, this commit pushes the image to ghcr.io as well.

Context

Fixes #5778

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@baloo baloo requested a review from edolstra as a code owner March 18, 2023 04:30
docker.com announced their intention to remove the free plan used by
OSS. The nixos/nix image is essential to various CI runs to build with
nix. To provide a continuity plan, this commit pushes the image to
ghcr.io as well.
@baloo baloo force-pushed the baloo/docker/publish-to-ghcr branch from 8d33b57 to 58546f1 Compare March 18, 2023 04:58
@baloo baloo requested a review from fricklerhandwerk as a code owner March 18, 2023 05:00
@SuperSandro2000
Copy link
Member

You can get a token with enough permissions with

permissions:
  contents: read
  packages: write

@baloo
Copy link
Member Author

baloo commented Mar 19, 2023

You can get a token with enough permissions with

permissions:
  contents: read
  packages: write

I missed that! Thank you!

@fricklerhandwerk
Copy link
Contributor

Triaged in the Nix team meeting 2023-03-23:

  • The NixOS Foundation is in the process of applying to the Docker OSS program, so less of a priority
  • postponed until there is more clarity on that application

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-03-23-nix-team-meeting-minutes-43/26758/1

@baloo
Copy link
Member Author

baloo commented Sep 27, 2023

@fricklerhandwerk would there be any update on this?
I'm now hitting the rate limits of anonymous pulls as defined https://www.docker.com/increase-rate-limits/

There is the option of setting up authentication in the CI, but a more convenient mirror would be most welcome!

Thanks!

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@fricklerhandwerk
Copy link
Contributor

Discussed in 2023-10-13 Nix team meeting:

@baloo sorry for the long delay, we have a very long tail of PRs to deal with.

This won't push the release tags, as they are pushed manually via the release script. We'll merge this as is to move forward. Could you also please update the release script to make it complete?

@fricklerhandwerk fricklerhandwerk merged commit 85e5ac4 into NixOS:master Oct 20, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-10-13-nix-team-meeting-minutes-94/34395/1

@baloo
Copy link
Member Author

baloo commented Oct 20, 2023

will do! Thank you for the merge!

@baloo baloo deleted the baloo/docker/publish-to-ghcr branch October 20, 2023 19:07
baloo added a commit to baloo/nix-1 that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Request: mirror the docker image to Github Container Registry (or somewhere else) to avoid rate limit

4 participants