Fix "unexpected EOF" errors on macOS #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this fixes "unexpected EOF" failures on macOS (NixOS#3137, NixOS#3605, NixOS#7242, NixOS#7702). The problem appears to be that under some circumstances, macOS discards the output written to the slave side of the pseudoterminal. Hence the parent never sees the "sandbox initialized" message from the child, even though it succeeded. The conditions are: * The child finishes very quickly. That's why this bug is likely to trigger in nix-env tests, since that uses a builtin builder. Adding a short sleep before the child exits makes the problem go away. * The parent has closed its duplicate of the slave file descriptor. This shouldn't matter, since the child has a duplicate as well, but it does. E.g. moving the close to the bottom of startBuilder() makes the problem go away. However, that's not a solution because it would make Nix hang if the child dies before sending the "sandbox initialized" message. * The system is under high load. E.g. "make installcheck -j16" makes the issue pretty reproducible, while it's very rare under "make installcheck -j1". As a fix/workaround, we now open the pseudoterminal slave in the child, rather than the parent. This removes the second condition (i.e. the parent no longer needs to close the slave fd) and I haven't been able to reproduce the "unexpected EOF" with this.
|
We should do #8023 as well, but I think the only overlap is the removal of writing |
7 tasks
1 task
|
This seems to have broken the daemon installer tests which now time out (https://hydra.nixos.org/build/213036858 and following). @edolstra any idea what might be going on? |
|
That's fixed by #8077. |
3 tasks
goodlyrottenapple
added a commit
to runtimeverification/evm-semantics
that referenced
this pull request
Mar 5, 2024
A newer version of nix should incorporate these fixes NixOS/nix#8049
rv-jenkins
added a commit
to runtimeverification/evm-semantics
that referenced
this pull request
Mar 6, 2024
* deps/pyk_release: Set Version v0.1.676
* kevm-pyk/: sync poetry files pyk version v0.1.676
* deps/k_release: sync release file version 6.3.25
* flake.{nix,lock}: update Nix derivations
* Set Version: 1.0.478
* deps/pyk_release: Set Version v0.1.678
* kevm-pyk/: sync poetry files pyk version v0.1.678
* flake.{nix,lock}: update Nix derivations
* deps/pyk_release: Set Version v0.1.679
* kevm-pyk/: sync poetry files pyk version v0.1.679
* flake.{nix,lock}: update Nix derivations
* deps/pyk_release: Set Version v0.1.680
* kevm-pyk/: sync poetry files pyk version v0.1.680
* flake.{nix,lock}: update Nix derivations
* Set Version: 1.0.479
* Set Version: 1.0.479
* deps/pyk_release: Set Version v0.1.681
* kevm-pyk/: sync poetry files pyk version v0.1.681
* flake.{nix,lock}: update Nix derivations
* Try newer version of nix
A newer version of nix should incorporate these fixes NixOS/nix#8049
* bump cachix action
* Update install-nix-action
* Set Version: 1.0.481
* kevm-pyk/: sync poetry files pyk version v0.1.681
* Set Version: 1.0.482
---------
Co-authored-by: devops <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Samuel Balco <[email protected]>
Co-authored-by: Everett Hildenbrandt <[email protected]>
runeksvendsen
added a commit
to runeksvendsen/dump-decls
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hopefully fixes #3137, #3605, #7242, #7702.
Context
See c536e00 for detailed explanation.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.