Support building the manual without make install#7888
Support building the manual without make install#7888jhgit wants to merge 4 commits intoNixOS:masterfrom
make install#7888Conversation
…stall of nix. This changes make target pre-requisites to point to build products within the working area instead the installed location. Without this, 'gmake all' will hit a dependency on $(bindir)/nix and try to install it (which will normally fail if building as a regular user). Fixes NixOS#7360 (Build fails ... /usr/local/lib/libnixutil.so: Permission denied)
|
I should add there was a change here that helps support different sed(1) implementations (for the non-portable -i feature). To that end, adding something like the following to the commit message seems reasonable: An alternative to using |
|
While this is waiting for a review, it would be helpful for someone with triage access to add the 'build problem' label. |
|
@jhgit thanks for your patience, and sorry for the delay. I think this is quite important, but we don't have the routine of sweeping up incoming PRs into the team's triage process. I do it sometimes and irregularly when I find a few minutes. I hope merging #6338 and aggressively prioritising by label will help... |
|
@jhgit I recommend pulling the path to the Nix binary to be used into a make variable. While this better for this PR, something @roberth at least has been pursuing is fine-grained derivations, for sake of quicker rebuilds etc. That would require changing that path to neither it's old or new value, but an external pre-built Nix in the Nix store. The only way we can support both use-cases with some more indirection in the form of a variable. So let's start there. |
|
(The build failure looks unrelated: it would appear that For now, just ignore it, hopefully it goes away next time. |
|
Indeed @Ericson2314's explanation seems sufficient and this does not seem like a relevant error. |
make install
|
Triaged in the Nix team meeting:
|
|
@jhgit Please use the factored-out variable. When you rebase and push again the error will probably go away. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-03-10-nix-team-meeting-minutes-39/26279/1 |
|
Closing as duplicate of #5145 |
This changes make target pre-requisites to point to build products within the working area instead the installed location.
Without this, 'gmake all' will hit a dependency on $(bindir)/nix and try to install it (which will normally fail if building as a regular user).
Fixes #7360 (Build fails ... /usr/local/lib/libnixutil.so: Permission denied)
Motivation
Allow full build as regular user. Avoid requiring install when just doing 'gmake all'
Context
Fixes #7360
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*