Skip to content

nix flakes metadata displays lastModified timestamp of inputs #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wfranzini wants to merge 1 commit into from
Closed

nix flakes metadata displays lastModified timestamp of inputs #7729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/nix/flake.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,11 @@ struct CmdFlakeMetadata : FlakeCommand, MixJSON
bool last = i + 1 == node.inputs.size();

if (auto lockedNode = std::get_if<0>(&input.second)) {
logger->cout("%s" ANSI_BOLD "%s" ANSI_NORMAL ": %s",
auto lastModified = (*lockedNode)->lockedRef.input.getLastModified ();
logger->cout("%s" ANSI_BOLD "%s" ANSI_NORMAL ": %s\t(%s)",
prefix + (last ? treeLast : treeConn), input.first,
(*lockedNode)->lockedRef);
(*lockedNode)->lockedRef,
std::put_time(std::localtime(&*lastModified), "%F %T"));
Copy link
Member

@edolstra edolstra Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash if lastModified is empty. You could use the describe() method in lockfile.cc, which does the following:

    auto s = fmt("'%s'", flakeRef.to_string());

    if (auto lastModified = flakeRef.input.getLastModified())
        s += fmt(" (%s)", std::put_time(std::gmtime(&*lastModified), "%Y-%m-%d"));


bool firstVisit = visited.insert(*lockedNode).second;

Expand Down